Skip to content

7904175: Empty option value can crash jextract#303

Open
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla:7904175
Open

7904175: Empty option value can crash jextract#303
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla:7904175

Conversation

@nizarbenalla
Copy link
Copy Markdown
Member

@nizarbenalla nizarbenalla commented Mar 31, 2026 •
edited by openjdk Bot
Loading

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Passing empty option values to jextract causes it to crash, this patch prevent that to happen.

Please add the following to the description of the pull request:

  1. A brief recap of the status quo, as it relates to the subject of the pull request.
  2. A description of why the status quo is problematic.
  3. A description of how this pull request addresses this issue.
  4. If you ran into issues while making changes in the code that you had to work around,
    please mention these as well, as this helps reviewers understand the changes that have been made.

For 1 and 2 it is also okay to refer to the JBS ticket, if that already contains a comprehensive
problem description.

Please test your pull request before submitting it by running ./gradlew jtreg. If you're
not able to test locally on your machine, please indicate this in the pull request description,
and indicate which testing has been done instead (or indicate that no testing has been done).

It is possible to run tests through Github actions if you enable them for your fork (this is free).
Github actions can be enabled for your fork from the 'Actions' tab. The tests will then run
automatically after the pull request has been created.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Error

 ⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.org/jextract.git pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/303.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 31, 2026

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 31, 2026 •
edited
Loading

@nizarbenalla This change is no longer ready for integration - check the PR body for details.

@nizarbenalla nizarbenalla marked this pull request as ready for review March 31, 2026 12:28
@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 31, 2026

Webrevs

JornVernee
JornVernee approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the option parser code, but your changes look good to me.

@nizarbenalla
Copy link
Copy Markdown
Member Author

nizarbenalla commented Apr 27, 2026

Thank you for the review

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Apr 27, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 27, 2026

@nizarbenalla
Your change (at version d2218ae) is now ready to be sponsored by a Committer.

@openjdk openjdk Bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2026
@nizarbenalla
Copy link
Copy Markdown
Member Author

nizarbenalla commented Apr 27, 2026

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 27, 2026

@nizarbenalla The pull request template has been appended to the pull request body

@nizarbenalla
Copy link
Copy Markdown
Member Author

nizarbenalla commented Apr 28, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 28, 2026

@nizarbenalla Your integration request cannot be fulfilled at this time, as the status check jcheck-openjdk/jextract-303 did not complete successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JornVernee JornVernee JornVernee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nizarbenalla @JornVernee